fix: make all tests pass — implement missing utilities and fix edge-case bugs - #269
Open
stooit wants to merge 1 commit into
Open
fix: make all tests pass — implement missing utilities and fix edge-case bugs#269stooit wants to merge 1 commit into
stooit wants to merge 1 commit into
Conversation
…ests - calculator: divide now throws on division by zero - date-utils: fix off-by-one/rounding overflow in formatRelative unit buckets - string-utils: implement truncate (word-boundary + ...) and fix wordCount for consecutive spaces - task-manager: implement remove, update, and sortBy (priority/createdAt) - validator: broaden isEmail (long TLDs) and isUrl (host:port) regexes All 60 tests pass. No test files or dependencies changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 16 previously-failing tests across the utility library. All 60 tests now pass (
bun test),tsc --noEmitis clean, and no previously-passing tests were broken.Changes
src/calculator.ts—dividenow throws on division by zero instead of returningInfinity/NaN.src/date-utils.ts— Fixed the off-by-one / rounding-overflow bug informatRelative. Buckets are chosen after rounding, so top-of-bucket values roll up correctly (e.g. 59.6 min → "1 hour ago", 23.6 h → "1 day ago") instead of emitting "60 minutes ago".src/string-utils.ts— Implementedtruncate(word-boundary truncation with"..."counting towardmaxLength; unchanged whenstr.length <= maxLength). FixedwordCountfor consecutive spaces.src/task-manager.ts— Implementedremove,update, andsortBy(priority high→medium→low;createdAtoldest-first).remove/updatereturnfalsefor unknown ids.src/validator.ts— BroadenedisEmail(long TLDs, e.g..museum) andisUrl(host with port, e.g.http://localhost:3000).Verification
bun test→ 60 pass / 0 failtsc --noEmitcleanformatRelative, fixed before this PR.Assumptions & scope