fix: implement missing utility functions and fix edge-case bugs - #267
Open
stooit wants to merge 1 commit into
Open
fix: implement missing utility functions and fix edge-case bugs#267stooit wants to merge 1 commit into
stooit wants to merge 1 commit into
Conversation
Fixes 16 failing tests across the library: - calculator: divide now throws on division by zero - string-utils: fix wordCount for consecutive spaces; implement truncate - task-manager: implement remove, update, and sortBy - date-utils: fix off-by-one in formatRelative day rounding - validator: fix isEmail long-TLD and isUrl port edge cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 16 failing tests across the TypeScript utility library. 60 pass, 0 fail after the change (was 44 pass / 16 fail),
tsc --noEmitclean, no test files modified, no new dependencies.Changes by file
src/calculator.ts—dividenow throwsError("Division by zero")when the divisor is0.src/string-utils.ts—wordCounthandles multiple consecutive spaces;truncateimplemented (returns unchanged when within limit, truncates at a word boundary,"..."counts towardmaxLength, handles strings shorter than the ellipsis).src/task-manager.ts— implemented the missingremove,update, andsortBymethods (sort by priority high→medium→low, and bycreatedAtoldest-first).src/date-utils.ts— fixed an off-by-one informatRelativeday rounding (36 hours now reports "1 day ago").src/validator.ts—isEmailaccepts long TLDs;isUrlaccepts URLs with an explicit port.Verification
bun test-> 60 pass, 0 fail, stable across repeated runs.Assumptions