fix: implement missing utilities and fix edge-case bugs - #263
Open
stooit wants to merge 1 commit into
Open
Conversation
- calculator: guard divide against division by zero - string-utils: implement truncate (word-boundary, ... counts toward maxLength); fix wordCount for consecutive spaces - task-manager: add remove/update/sortBy (priority high>medium>low, createdAt oldest-first) - date-utils: fix formatRelative off-by-one at hour/day boundaries - validator: allow long TLDs in isEmail and ports in isUrl All 60 tests pass; no test files or dependencies changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 16 previously failing tests across the utility library. The full suite now passes (60 pass / 0 fail). No test files were modified and no dependencies were added.
Changes
src/calculator.tsdividenow throws on division by zerosrc/string-utils.tstruncate(word-boundary,"..."counts towardmaxLength, unchanged whenstr.length <= maxLength); fixedwordCountfor consecutive spacessrc/task-manager.tsremove,update, andsortBy(priority high > medium > low;createdAtoldest-first)src/date-utils.tsformatRelativeat the hour/day boundarysrc/validator.tsisEmailaccepts long TLDs (e.g.user@example.museum);isUrlaccepts ports (e.g.http://localhost:3000)Stale
// BUG:JSDoc comments describing the now-fixed defects were removed to avoid misleading future readers.Testing
bun test→ 60 pass, 0 fail, 70 expect() calls.Assumptions
truncatebehaviour formaxLength < 4is not exercised by any test and was left as-is rather than over-engineering an uncovered edge case.Verification
codeagent, independently verified viabun test.reviewagent — no correctness blockers.