fix: implement missing utilities and fix edge-case bugs - #262
Open
stooit wants to merge 1 commit into
Open
Conversation
- calculator: guard divide against division by zero - string-utils: implement truncate (word-boundary + ellipsis) and fix wordCount for consecutive spaces - task-manager: implement remove, update, and sortBy - date-utils: fix off-by-one in formatRelative (round instead of floor) - validator: fix isEmail for long TLDs/subdomains and isUrl for ports (use URL constructor)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes all 16 previously-failing tests pass while keeping the existing 44 green (60/60 pass). Fixes were limited to source files only — no test files or dependencies were touched.
Changes by file
src/calculator.ts—dividenow throwsError("Division by zero")when the divisor is0.src/string-utils.ts— implementedtruncate(word-boundary truncation with the"..."ellipsis counted towardmaxLength, plus a fallback whenmaxLength <= 3); fixedwordCountto collapse multiple consecutive spaces.src/task-manager.ts— implementedremove(returnsfalsefor unknown id),update(in-place update,falsefor unknown id), andsortByforcreatedAt(oldest first) andpriority(high → medium → low).src/date-utils.ts— fixed off-by-one informatRelativeby rounding rather than flooring the day delta (36h now reads as "1 day ago").src/validator.ts—isEmailnow accepts subdomains and long TLDs (e.g..museum);isUrlrewritten to use the standardURLconstructor so ports (e.g.http://localhost:3000) validate correctly.Verification
bun test→ 60 pass, 0 fail.Assumptions
updaterestricts mutable fields totitle/priorityto matchTaskManagersemantics.sortBycopies before sorting so the internal store order is not mutated.