fix: pass all failing tests and implement missing utility functionality - #260
Open
stooit wants to merge 1 commit into
Open
fix: pass all failing tests and implement missing utility functionality#260stooit wants to merge 1 commit into
stooit wants to merge 1 commit into
Conversation
…ests - calculator: divide now throws on division by zero - string-utils: implement truncate (word-boundary) and fix wordCount for consecutive spaces - task-manager: implement sortBy for priority/createdAt with correct ordering - date-utils: fix off-by-one in date formatting - validator: relax isEmail TLD length and allow ports in isUrl All 60 tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 16 previously-failing tests in the utility library. The suite now passes 60/60 with no changes to test files and no new dependencies.
Changes
src/calculator.tsdividenow throwsError("Division by zero")when the divisor is0src/string-utils.tstruncate(word-boundary,"..."counting towardmaxLength); fixedwordCountto split on/\s+/so consecutive spaces don't inflate the countsrc/task-manager.tssortBy—priorityuses an explicit rank map (high→medium→low),createdAtsorts chronologicallysrc/date-utils.tssrc/validator.tsisEmailaccepts long TLDs (e.g..museum);isUrlaccepts URLs with ports (e.g.http://localhost:3000)Verification
bun test→ 60 pass, 0 fail (70 expect() calls, 5 files)Assumptions
Out-of-scope observations (not fixed — no test coverage, would expand scope)
A review surfaced three latent defects in untested code paths. Flagging for a future PR rather than fixing here to respect the "fix only what tests require" constraint:
TaskManager.sortBy('status')sorts alphabetically (completed→in_progress→pending), i.e. reverse workflow order.truncateuseslastSpace > 0rather than>= 0, mishandling a leading-space window edge case.formatRelativeusesMath.round, which can render a ~23h50m gap as"24 hours ago".🤖 Generated with QuantCode Agent