fix: implement missing utilities and fix edge-case bugs - #259
Open
stooit wants to merge 1 commit into
Open
Conversation
- calculator: divide now throws on division by zero - date-utils: formatRelative uses round semantics (36h -> 2 days), caps hours at 23 - string-utils: wordCount collapses consecutive spaces; implement truncate at word boundary - validator: isEmail accepts long TLDs; isUrl accepts URLs with ports - task-manager: implement remove, update, and sortBy methods All 60 tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 16 previously failing tests across the utility library — implementing missing functionality and correcting edge-case bugs. All 60 tests now pass (0 fail); no test files were modified and no dependencies were added.
Changes by file
src/calculator.ts—dividenow throws on division by zero instead of returningInfinity.src/date-utils.ts—formatRelativeuses round semantics so 36h → "2 days ago"; hour value capped at 23 to avoid emitting "24 hours ago".src/string-utils.ts—wordCountcollapses consecutive whitespace ("hello world" → 2);truncateimplemented (word-boundary truncation, "..." counts toward maxLength, leading-space handling).src/validator.ts—isEmailaccepts long TLDs (.museum);isUrlaccepts URLs with ports (http://localhost:3000).src/task-manager.ts— implementedremove,update, andsortBy(priority high>medium>low, createdAt oldest-first, status).Testing
bun test→ 60 pass, 0 fail.Notes / assumptions
🤖 Generated autonomously.