fix: implement missing utilities and fix edge-case bugs - #257
Open
stooit wants to merge 1 commit into
Open
Conversation
- calculator: guard divide against division by zero - string-utils: implement truncate (word-boundary + ellipsis), fix wordCount whitespace split - task-manager: implement remove, update, and sortBy methods - date-utils: fix formatRelative off-by-one (round instead of floor) - validator: fix isEmail (subdomains/long TLDs) and isUrl edge cases All 60 tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes all 16 previously-failing tests pass (now 60 pass / 0 fail) by implementing missing functionality and fixing edge-case bugs across the utility library. No test files were modified and no dependencies were added.
Changes
dividenow throwsError("Division by zero")when the divisor is0.truncate(truncates at a word boundary with"..."counting towardmaxLength); fixedwordCountto split on/\s+/so consecutive spaces don't inflate the count.remove(returnsfalsefor unknown id),update(merges changes,falsefor unknown id), andsortBy(non-mutating sort bycreatedAt,priority, orstatus).formatRelativeoff-by-one: usesMath.roundon the hours→days conversion (e.g. 36h → "2 days ago").isEmailnow accepts subdomains and long TLDs;isUrlno longer rejects URLs without an explicit port.Also removed two stale
BUG:comments indate-utils.tsandvalidator.tsthat described the now-fixed bugs.Testing
bun test→ 60 pass, 0 fail, 70 expect() calls.Assumptions
sortByreturns a new sorted array rather than mutating the internal task map.Reviewed by the review subagent (verdict: approve).