fix: repair failing tests and type errors across api and shared packages

packages/api/src/middleware/auth.ts

@@ -7,17 +7,13 @@ import type { MiddlewareHandler } from "hono"
  *   GET, POST  → public (no token required)
  *   PUT, DELETE, PATCH → require Bearer token
  *
- * BUG: The allow-list check uses `'post'` (lowercase) instead of `'POST'`.
- * HTTP methods are always uppercase per RFC 7231, so POST is never matched
- * as a public method — POST requests incorrectly require a token.
- *
- * Fix: change `'post'` to `'POST'` in the public methods array.
+ * HTTP method tokens are case-sensitive and uppercase per RFC 7231 §4, so the
+ * allow-list is compared against the normalised (uppercased) request method.
  */
-export const authMiddleware: MiddlewareHandler = async (c, next) => {
-  // BUG: 'post' should be 'POST' — POST is never treated as public
-  const publicMethods = ["GET", "post"]
+const PUBLIC_METHODS = ["GET", "POST"]
 
-  if (publicMethods.includes(c.req.method)) {
+export const authMiddleware: MiddlewareHandler = async (c, next) => {
+  if (PUBLIC_METHODS.includes(c.req.method.toUpperCase())) {
     return next()
   }
 

packages/api/src/routes/users.ts

@@ -1,9 +1,6 @@
 import { Hono } from "hono"
 import { db } from "../lib/db"
-import { notFound } from "../lib/errors"
-// BUG: missing import — `badRequest` is used below but not imported here.
-// This causes a ReferenceError at runtime when POST /users is called with invalid data.
-// Fix: add `badRequest` to the import from "../lib/errors"
+import { badRequest, notFound } from "../lib/errors"
 
 const router = new Hono()
 
@@ -20,7 +17,6 @@ router.get("/:id", (c) => {
 router.post("/", async (c) => {
   const body = await c.req.json().catch(() => null)
   if (!body || !body.username || !body.email) {
-    // BUG: badRequest is not imported — this will throw ReferenceError
     return badRequest(c, "username and email are required")
   }
   const user = db.users.create({ username: body.username, email: body.email })

packages/shared/src/types.ts

@@ -1,14 +1,10 @@
 /**
  * Shared types used by both the API and any consumers.
- *
- * BUG: The field is named `userName` here but the API routes reference `username`
- * (lowercase n). This causes a type error in routes/users.ts and a runtime
- * mismatch when serialising responses.
  */
 
 export type User = {
   id: string
-  userName: string // BUG: should be `username` to match API usage
+  username: string
   email: string
   createdAt: string
 }

packages/shared/src/utils/pagination.ts

@@ -7,9 +7,27 @@ import type { PaginatedResponse } from "../types"
  * @param page   1-indexed page number
  * @param size   Number of items per page
  *
- * TODO: implement this function — it is currently a stub.
- * The test in packages/shared/test/pagination.test.ts exercises the full contract.
+ * Pages outside the available range yield an empty `data` array while still
+ * reporting the requested `page`/`pageSize` alongside the true totals.
+ *
+ * `page` and `size` are normalised to finite integers so the returned
+ * `page`/`pageSize` always satisfy the declared `number` contract — a NaN or
+ * Infinity would otherwise serialise to `null` through `JSON.stringify`.
+ * Non-finite `size` (and any `size <= 0`) collapses to a `pageSize` of 0;
+ * non-finite or sub-1 `page` clamps to the first page.
  */
 export function paginate<T>(items: T[], page: number, size: number): PaginatedResponse<T> {
-  throw new Error("not implemented")
+  const total = items.length
+  const pageSize = Number.isFinite(size) ? Math.max(0, Math.floor(size)) : 0
+  const currentPage = Number.isFinite(page) ? Math.max(1, Math.floor(page)) : 1
+  const totalPages = pageSize > 0 ? Math.ceil(total / pageSize) : 0
+  const start = (currentPage - 1) * pageSize
+
+  return {
+    data: pageSize > 0 ? items.slice(start, start + pageSize) : [],
+    page: currentPage,
+    pageSize,
+    total,
+    totalPages,
+  }
 }

tsconfig.json

@@ -5,6 +5,8 @@
     "moduleResolution": "bundler",
     "strict": true,
     "skipLibCheck": true,
+    "lib": ["ES2022"],
+    "types": ["bun-types"],
     "paths": {
       "@e2e/shared": ["./packages/shared/src/index.ts"]
     }