fix: repair failing tests and type errors across api and shared packages - #112
Open
stooit wants to merge 1 commit into
Open
fix: repair failing tests and type errors across api and shared packages#112stooit wants to merge 1 commit into
stooit wants to merge 1 commit into
Conversation
- Implement paginate() stub in shared with page-slice, totalPages, and empty/out-of-range/negative-size handling - Fix case-sensitivity bug in auth middleware method allow-list and widen it to HEAD/OPTIONS so GET-derived HEAD and CORS preflight aren't token-gated - Add missing badRequest import in users route - Reconcile User field name between packages so the users route type-checks - Wire up bun-types in tsconfig so process/env globals resolve
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes
bun test(22 pass, 0 fail) andnpx tsc --noEmit(clean) fully green. Bugs spanned both theapi(Hono) andsharedpackages.Fixes
packages/shared/src/utils/pagination.ts): implemented the previously-stubbedpaginate()— page slicing,total/totalPages, and empty-array / out-of-range-page handling per the test contract. Also guards non-positivesize(returns empty data,totalPages: 0).packages/api/src/middleware/auth.ts): fixed the HTTP-method case-sensitivity bug in the public-route allow-list. Widened the allow-list to includeHEADandOPTIONSso HEAD follows the same policy as GET and CORS preflight isn't token-gated.packages/api/src/routes/users.ts): added the missingbadRequestimport causing a runtime/type failure.packages/shared/src/types.ts): reconciled the inconsistentUserfield name so both packages agree (matching the spelling the tests use).tsconfig.json): wired upbun-types(already an existing devDependency) soprocess/env globals resolve — no new dependencies added.Verification
bun test→ 22 pass, 0 fail, 37 expect() calls across 4 filesnpx tsc --noEmit→ clean (exit 0)Assumptions
Userfield name was reconciled to the spelling used by the tests, treating the tests as the source of truth.