fix: repair failing tests and type errors across api and shared - #110
Open
stooit wants to merge 1 commit into
Open
fix: repair failing tests and type errors across api and shared#110stooit wants to merge 1 commit into
stooit wants to merge 1 commit into
Conversation
- Implement paginate() in shared (was a stub); guard non-finite page/size - Reconcile User field name to `username` across api and shared - Add missing badRequest import in users route (fixes 400 handler) - Fix case-sensitive HTTP method check in auth middleware public routes - Wire up bun-types in tsconfig so process/bun:test resolve All 22 tests pass; tsc --noEmit is clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 9 failing tests and 14
tsc --noEmiterrors in the api/shared multi-package repo. Baseline was 9 fail / 14 type errors → now 22 pass / 0 fail and tsc clean.Fixes
shared): implementedpaginate()(was anot implementedstub) — page slicing,total,totalPages,page/pageSize, empty/out-of-range handling. Also guards non-finitepage/sizewithNumber.isFinite(preventsNaN→nullserialization and anInfinity-driven unbounded-response path).Userfield name tousernameconsistently across both packages (tests expected the shared type's name; source now matches).api): added the missingbadRequestimport inroutes/users.ts— fixesPOST /users400-on-missing-fields.api): fixed a case-sensitive HTTP-method comparison so public routes (e.g.POST /users) are recognized regardless of method casing.process/bun:testresolve. No new dependencies added.Verification
bun test→ 22 pass / 0 failnpx tsc --noEmit→ clean (exit 0)Assumptions
Usertype (per instructions not to modify tests).typeswere wired to packages already present innode_modules; nothing was installed.Notes