fix: repair failing tests and type errors across api and shared packages - #109
Open
stooit wants to merge 1 commit into
Open
fix: repair failing tests and type errors across api and shared packages#109stooit wants to merge 1 commit into
stooit wants to merge 1 commit into
Conversation
- auth: normalise HTTP method comparison so POST /users is public (was case-sensitive) - shared types: rename User.userName -> username for cross-package consistency - users route: add missing badRequest/notFound imports - pagination: implement paginate() per test contract - tsconfig: add bun-types so process and bun:test resolve
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all failing tests and eliminates all
tsc --noEmittype errors across theapiandsharedpackages.bun test && tsc --noEmitis now fully green: 22 pass / 0 fail, tsc exit 0.Root causes & fixes
packages/api/src/middleware/auth.ts) — HTTP method comparison for public routes was case-sensitive, soPOST /userswas not recognised as public and required a token. Normalised the method comparison and removed dead code around the branch.packages/shared/src/types.ts) — field-name inconsistency on theUsertype between packages caused atscerror at the users route. Made the field name consistent with what the route/tests expect.packages/api/src/routes/users.ts) — missing import(s) (e.g.badRequest) caused aCannot find nametype error / runtime failure. Added the missing import(s).packages/shared/src/utils/pagination.ts) — was a stub throwingnot implemented. Implementedpaginate()to the test contract: correct page slice, second/partial-last pages,total/totalPages,page/pageSize, and emptydatafor out-of-range pages.tsconfig.json—bun-typeswas installed but never wired into the compilertypes, soprocess(andbun:test) had no global declarations. Added it so these resolve without adding any dependency.Verification
bun test→ 22 pass, 0 failnpx tsc --noEmit→ exit 0Constraints honoured
bun-typeswas already installed).