fix: repair failing tests and type errors across api and shared packages - #103
Open
stooit wants to merge 1 commit into
Open
fix: repair failing tests and type errors across api and shared packages#103stooit wants to merge 1 commit into
stooit wants to merge 1 commit into
Conversation
- implement paginate() stub in shared with correct slicing and totals - wire bun-types into tsconfig for process/bun:test globals - import missing badRequest helper in users route - rename User.userName -> username for cross-package consistency - fix case-sensitivity bug in auth middleware public-route method check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all failing tests and eliminates all
tsc --noEmittype errors.bun testnow reports 22 pass / 0 fail and typecheck is clean.Changes
packages/shared/src/utils/pagination.ts— implemented thepaginate()stub (was throwingnot implemented): correct page slicing,total/totalPages,page/pageSize, and empty data for out-of-range pages.tsconfig.json— added"types": ["bun-types"](package already installed) soprocessandbun:testglobals resolve across both packages.packages/api/src/routes/users.ts— imported the missingbadRequesthelper that caused a failure in the users route.packages/shared/src/types.ts— renamedUser.userName→usernameto match the contract the tests expect, and updated all cross-package usages.packages/api/src/middleware/auth.ts— fixed a case-sensitivity bug in the public-route check soPOST /usersis correctly treated as public.Assumptions
username(tests unmodified).bun-typeswas already innode_modules.Verification
bun test→ 22 pass, 0 failbunx tsc --noEmit→ clean