fix: repair cross-package test and type failures - #86
Open
stooit wants to merge 1 commit into
Open
Conversation
- wire happy-dom preload in bunfig.toml so React tests get a DOM - add bun-types to tsconfig so tsc resolves bun:test - fix stale useThrottle->useDebounce import in apps/web api - forward aria-label on Button for accessible name - use functional updater in DataTable sort to fix stale closure - use en-AU dateStyle:short so formatDate is day-first, no zero-pad
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all failing tests and type errors across the monorepo (
packages/ui,packages/utils,apps/web). After changes: 13/13 tests pass,tsc --noEmitclean. No test files or dependencies were modified.Changes
bunfig.tomldocument is not defined. Addedpreload = ["./packages/ui/test/setup.ts"]so happy-dom'sGlobalRegistrator.register()runs before@testing-library/react'srender().tsconfig.jsonCannot find module 'bun:test'. Added"types": ["bun-types"]tocompilerOptions.apps/web/src/lib/api.tsuseThrottlewas renamed touseDebouncein@e2e/utils; updated the import and theas useSearchDebouncere-export.Button.tsxaria-labelprop was destructured but never applied. Now forwarded to the<button>(omitted by React when undefined, so other buttons are unaffected).DataTable.tsxsortDirfrom the closure. Switched to the functional updater formsetSortDir(prev => ...).packages/utils/src/format/date.tsen-AUwith{ dateStyle: "short" }for day-first, non-zero-padded days.Assumptions
bunfig.toml,tsconfig.json) are in scope; only test files were treated as off-limits.packages/ui/test/setup.tsalready registers happy-dom, so only the preload wiring was needed.en-AUis the intended locale (matches the pre-existing locale string; only the format options were wrong).Verification