Conversation
17 tests have been passing on my machine and nowhere else. They now run on every push against Temurin 17. EnergyServiceIntegrationTest is excluded. It builds a real RestTemplate and calls the NESO Carbon Intensity API, so a bad afternoon upstream would fail a build with nothing wrong in it. Tagged `integration` rather than deleted, because it is the only thing that catches a change in the response shape. `mvn test` still runs it locally. The Testing section said the repository structure "indicates" service-level tests. It now says what each class covers and how many assertions are behind that claim. Adds MIT: without a licence the default is all rights reserved.
Committed from Windows without the executable bit, so ./mvnw is a permission error on any Linux or macOS clone, CI included.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
17 tests were passing locally and nowhere else. They now run on every push against Temurin 17.
EnergyServiceIntegrationTestis left out of the CI run. It builds a realRestTemplateagainst the NESO Carbon Intensity API, so an outage upstream would fail a build with nothing wrong in it. It is taggedintegrationrather than deleted, because it is the only test that catches a change in the response shape, andmvn teststill runs it locally.The Testing section previously said the repository structure "indicates" service-level tests. It now lists what each class covers and the number of tests behind it.
Adds MIT.