[3.13] gh-153864: Fix curses window.insch() for non-ASCII characters on a wide build (GH-153865)#154154
Merged
serhiy-storchaka merged 1 commit intoJul 19, 2026
Conversation
…cters on a wide build (pythonGH-153865) On a wide build, winsch() does not locale-decode a byte above 127, unlike waddch(), so insch()/mvinsch() stored the wrong character for a non-ASCII byte of an 8-bit locale ('€' 0xA4 under ISO-8859-15 became U+00A4 '¤'). Decode the byte with btowc() and insert it as a wide character, as addch() effectively does. (cherry picked from commit 223cbff) Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
serhiy-storchaka
enabled auto-merge (squash)
July 19, 2026 15:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual backport of #153865; the automatic backport hit a conflict.
3.13 predates the 3.15 error-handling refactor, so the wide-character path is written in 3.13's
addch()idiom:setcchar(..., PAIR_NUMBER(...), NULL)+wins_wch/mvwins_wch, returning through the module-levelPyCursesCheckERR().Verified on a wide (
HAVE_NCURSESW) build:test_output_characterpasses underISO-8859-15where€(0xA4) exercises the fix, and the fulltest_cursesis green there.