Skip to content

Add test for explicit cls argument bypassing default JSON decoder#154094

Merged
tomasr8 merged 3 commits into
python:mainfrom
GovernmentPlates:fix-json-test-cls-none
Jul 19, 2026
Merged

Add test for explicit cls argument bypassing default JSON decoder#154094
tomasr8 merged 3 commits into
python:mainfrom
GovernmentPlates:fix-json-test-cls-none

Conversation

@GovernmentPlates

@GovernmentPlates GovernmentPlates commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@bedevere-app bedevere-app Bot added tests Tests in the Lib/test dir awaiting review labels Jul 19, 2026
@tomasr8 tomasr8 added the sprint label Jul 19, 2026
@github-project-automation github-project-automation Bot moved this to Todo in Sprint Jul 19, 2026
picnixz
picnixz reviewed Jul 19, 2026
View reviewed changes
Comment thread Lib/test/test_json/test_decode.py
picnixz
picnixz reviewed Jul 19, 2026
View reviewed changes
Comment thread Lib/test/test_json/test_decode.py
picnixz
picnixz reviewed Jul 19, 2026
View reviewed changes
Comment thread Lib/test/test_json/test_decode.py Outdated
tomasr8
tomasr8 reviewed Jul 19, 2026
View reviewed changes
Comment thread Lib/test/test_json/test_decode.py Outdated
@GovernmentPlates GovernmentPlates changed the title Add test for skipped cls=None case in json.loads() Add test for explicit cls argument bypassing default JSON decoder Jul 19, 2026
picnixz
picnixz reviewed Jul 19, 2026
View reviewed changes
Comment thread Lib/test/test_json/test_decode.py
@github-project-automation github-project-automation Bot moved this from Todo to In Progress in Sprint Jul 19, 2026
@tomasr8 tomasr8 added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Jul 19, 2026
@tomasr8
tomasr8 merged commit 5380589 into python:main Jul 19, 2026
58 checks passed
@miss-islington-app

miss-islington-app Bot commented Jul 19, 2026

Copy link
Copy Markdown

Thanks @GovernmentPlates for the PR, and @tomasr8 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖

@github-project-automation github-project-automation Bot moved this from In Progress to Done in Sprint Jul 19, 2026
@bedevere-app

bedevere-app Bot commented Jul 19, 2026

Copy link
Copy Markdown

GH-154112 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jul 19, 2026
@bedevere-app

bedevere-app Bot commented Jul 19, 2026

Copy link
Copy Markdown

GH-154113 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jul 19, 2026
@bedevere-app

bedevere-app Bot commented Jul 19, 2026

Copy link
Copy Markdown

GH-154114 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jul 19, 2026
tomasr8 pushed a commit that referenced this pull request Jul 19, 2026
@miss-islington @GovernmentPlates
[3.13] Add test for explicit cls argument bypassing default JSON de…
303d0ac 
…coder (GH-154094) (#154114)

Add test for explicit `cls` argument bypassing default JSON decoder (GH-154094)

* Add test for skipped `cls=None` case

* Fix lint

* Add new line between classes
(cherry picked from commit 5380589)

Co-authored-by: Dominic H <dom@dominic.sk>
tomasr8 pushed a commit that referenced this pull request Jul 19, 2026
@miss-islington @GovernmentPlates
[3.14] Add test for explicit cls argument bypassing default JSON de…
2b807eb 
…coder (GH-154094) (#154113)

Add test for explicit `cls` argument bypassing default JSON decoder (GH-154094)

* Add test for skipped `cls=None` case

* Fix lint

* Add new line between classes
(cherry picked from commit 5380589)

Co-authored-by: Dominic H <dom@dominic.sk>
tomasr8 pushed a commit that referenced this pull request Jul 19, 2026
@miss-islington @GovernmentPlates
[3.15] Add test for explicit cls argument bypassing default JSON de…
9f7c44f 
…coder (GH-154094) (#154112)

Add test for explicit `cls` argument bypassing default JSON decoder (GH-154094)

* Add test for skipped `cls=None` case

* Fix lint

* Add new line between classes
(cherry picked from commit 5380589)

Co-authored-by: Dominic H <dom@dominic.sk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz left review comments
@tomasr8 tomasr8 tomasr8 approved these changes

Assignees

No one assigned

Labels

skip issue skip news sprint tests Tests in the Lib/test dir

Projects

Sprint
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GovernmentPlates @tomasr8 @picnixz