gh-153854: Raise ValueError from imaplib.Time2Internaldate on empty string#153874
Open
fedonman wants to merge 1 commit into
Open
gh-153854: Raise ValueError from imaplib.Time2Internaldate on empty string#153874fedonman wants to merge 1 commit into
fedonman wants to merge 1 commit into
Conversation
|
All commit authors signed the Contributor License Agreement. |
fedonman
force-pushed
the
fix-gh-153854-imaplib-time2internaldate
branch
from
July 18, 2026 09:43
d5e9b5d to
e99e4c2
Compare
fedonman
requested review from
a team,
1st1,
AA-Turner,
asvetlov,
emmatyping,
kumaraditya303 and
willingc
as code owners
July 18, 2026 09:43
…mpty string Time2Internaldate() is documented to raise ValueError for input that is not of a known type, and its final branch does so. However, the string branch subscripted the value with date_time[0]/date_time[-1] before that check, so an empty string escaped as a bare IndexError. Use str.startswith() and str.endswith() instead, which handle the empty string gracefully while preserving behaviour for every other input.
fedonman
force-pushed
the
fix-gh-153854-imaplib-time2internaldate
branch
from
July 18, 2026 09:48
0b78032 to
e5bd248
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
imaplib.Time2Internaldateis documented to raiseValueErrorfor input it doesn't recognize, and its final branch does exactly that. The problem is that the branch handling strings looks atdate_time[0]anddate_time[-1]before reaching that point, so passing an empty string raisedIndexErrorinstead:This switches that check to
str.startswith('"')andstr.endswith('"'), which handle the empty string fine. A properly quoted string still passes through unchanged, and anything else still raisesValueError.I added regression tests for the empty and malformed string cases and for the quoted-string passthrough.