Skip curses tests when scr_dump()/is_keypad() are unavailable#153866
Merged
serhiy-storchaka merged 1 commit intoJul 17, 2026
Conversation
test_scr_dump() and test_state_getters() errored instead of skipping on builds without scr_dump(), is_keypad() or is_leaveok() (e.g. some narrow ncurses, NetBSD, PDCurses). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
serhiy-storchaka
enabled auto-merge (squash)
July 17, 2026 21:30
fedonman
pushed a commit
to fedonman/cpython
that referenced
this pull request
Jul 18, 2026
…GH-153866) test_scr_dump() and test_state_getters() errored instead of skipping on builds without scr_dump(), is_keypad() or is_leaveok() (e.g. some narrow ncurses, NetBSD, PDCurses).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_scr_dump()andtest_state_getters()errored withAttributeErrorinstead of skipping on curses builds that lackscr_dump(),is_keypad()oris_leaveok()— these are conditionally compiled, so they are absent on some builds (e.g. narrow ncurses, NetBSD curses, PDCurses). Standard wide-ncurses buildbots have them all, which is why this went unnoticed.test_scr_dump()now uses@requires_curses_func('scr_dump'), and the getter loop intest_state_getters()skips a getter that the window does not provide.