gh-153236: Propagate lazy submodule import errors#153237
Merged
Merged
Conversation
pablogsal
requested review from
DinoV,
FFY00,
Yhg1s,
brettcannon,
ericsnowcurrently,
kumaraditya303,
ncoghlan and
warsaw
as code owners
July 6, 2026 23:04
Member
Author
|
CC @brittanyrey |
pablogsal
force-pushed
the
gh-153236-lazy-submodule-errors
branch
from
July 6, 2026 23:14
9a3039d to
1c296cf
Compare
brettcannon
removed their request for review
July 7, 2026 18:01
kumaraditya303
removed their request for review
July 8, 2026 09:35
johnslavik
self-requested a review
July 18, 2026 11:06
pablogsal
force-pushed
the
gh-153236-lazy-submodule-errors
branch
from
July 18, 2026 11:31
1c296cf to
d183e5f
Compare
pablogsal
force-pushed
the
gh-153236-lazy-submodule-errors
branch
from
July 18, 2026 11:49
d183e5f to
9a64b35
Compare
pablogsal
added
the
needs backport to 3.15
|
Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.15. |
|
GH-153936 is a backport of this pull request to the 3.15 branch. |
bedevere-app
Bot
removed
the
needs backport to 3.15
pablogsal
added a commit
that referenced
this pull request
Jul 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have chosen to make lazy submodule resolution explicit instead of classifying the exception after a failed import. A real module can raise
ModuleNotFoundErrorwith its own name while executing, so the exception doesn reliably tell us whether the finder failed or the loader failed.I think the superior way here is to do this in importlib's find/load boundary. No spec means the lazy submodule is absent and attribute lookup can continue. Once a spec exists, the submodule is real, so any later exception propagates normally.