fix(markers): reject backslashes in marker values - #1403
Open
WSks-ui wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1399.
Backslashes are currently accepted in quoted marker values, but they are interpreted as Python string escapes during parsing and emitted without escaping during serialization. As a result, a marker can change meaning after
str(marker)and reparsing.Reject unsupported backslashes while parsing marker values, following the marker grammar and the guidance in #1399. This prevents invalid input from silently changing semantics during serialization while preserving the existing output for valid markers.
Tests:
Metadata.as_rfc822().twine check --strictpass locally.