Warn when python_version markers aren't valid PEP 440 versions - #1398
Open
gyanu2507 wants to merge 2 commits into
Open
Warn when python_version markers aren't valid PEP 440 versions#1398gyanu2507 wants to merge 2 commits into
gyanu2507 wants to merge 2 commits into
Conversation
Author
|
The Both runs fail on the same single test with the same assertion: That's twine's own README-rendering check, which doesn't go through marker evaluation. The other 61 checks here pass. |
Contributor
|
Thanks! Fixing the CI in #1400. |
henryiii
force-pushed
the
marker-invalid-version-warn
branch
from
September 2, 2026 04:06
421b9f0 to
9eff8b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
python_version >= "3.9."isn't a PEP 440 version, so the comparison currently falls back to string compare with no indication (and"3.10" >= "3.9."is False).Warn for
< <= == != >= >onpython_version/python_full_versionwhen that happens.in/not inandplatform_releaseare unchanged.Fixes #633