perf: add __slots__ to Requirement - #1320
Merged
Merged
Conversation
Adapt the legacy-pickle branch in __setstate__ to restore attributes via setattr, since slotted instances have no __dict__. Assisted-by: ClaudeCode:claude-fable-5
henryiii
marked this pull request as ready for review
July 7, 2026 16:36
notatallshaw
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looking at #1252, the first step toward making these immutable is adding slots. This is the only remaining one missing one of the major classes that would benefit (not counting dataclasses).
🤖 AI text below 🤖
Adds
__slots__toRequirement, matchingVersion,Specifier,SpecifierSet,Marker, andTag.The legacy-pickle branch in
__setstate__(for pickles from packaging <= 26.1, which stored a plain__dict__) now restores attributes viasetattr, since slotted instances have no__dict__. The existing tests that load real pickle bytes from packaging 25.0/26.0/26.1 cover that path; a new test asserts instances have no__dict__.