Skip to content

Trigger unified-docs deployment on every push to main - #1193

Merged
Kludex merged 1 commit into
mainfrom
deploy-docs-on-main
Sep 4, 2026
Merged

Trigger unified-docs deployment on every push to main#1193
Kludex merged 1 commit into
mainfrom
deploy-docs-on-main

Conversation

@samuelcolvin

@samuelcolvin samuelcolvin commented Sep 4, 2026

Copy link
Copy Markdown
Member

The unified-docs library config for httpx2 pins its source to the main branch, so any rebuild of the unified site already pulls httpx2 docs from main. Dispatching only on tag pushes meant a release deployed docs at the tag SHA, and the next unrelated rebuild of the site would pull newer main content anyway. Logfire already dispatches on every push to main for the same reason.

This moves the deploy-docs job from publish.yml to main.yml. It depends on the check job and runs only when success() && github.ref == 'refs/heads/main', so pull requests and failed test runs skip it. The dispatch payload still pins the exact commit SHA.

Review in cubic

unified-docs pins httpx2 to the main branch, so docs should be
redeployed whenever main changes rather than only on tag pushes.
@codspeed-hq

codspeed-hq Bot commented Sep 4, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 17 untouched benchmarks
⏩ 7 skipped benchmarks1


Comparing deploy-docs-on-main (2e908f6) with main (32c40d9)

Open in CodSpeed

Footnotes

  1. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Re-trigger cubic

@Kludex
Kludex merged commit aaef581 into main Sep 4, 2026
19 checks passed
@Kludex
Kludex deleted the deploy-docs-on-main branch September 4, 2026 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants