Trigger unified-docs deployment on every push to main - #1193
Merged
Conversation
unified-docs pins httpx2 to the main branch, so docs should be redeployed whenever main changes rather than only on tag pushes.
Merging this PR will not alter performance
Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unified-docs library config for httpx2 pins its source to the
mainbranch, so any rebuild of the unified site already pulls httpx2 docs from main. Dispatching only on tag pushes meant a release deployed docs at the tag SHA, and the next unrelated rebuild of the site would pull newer main content anyway. Logfire already dispatches on every push to main for the same reason.This moves the
deploy-docsjob frompublish.ymltomain.yml. It depends on thecheckjob and runs only whensuccess() && github.ref == 'refs/heads/main', so pull requests and failed test runs skip it. The dispatch payload still pins the exact commit SHA.