Fix TypeError in dc_ohms_from_percent for single-array list input#2830
Open
SAY-5 wants to merge 1 commit into
Open
Fix TypeError in dc_ohms_from_percent for single-array list input#2830SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
Hey @SAY-5! 🎉Thanks for opening your first pull request! We appreciate your If AI is used for any portion of this PR, you must vet the content |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dc_ohms_from_percentfails on single-Array ModelChain with list input #2829docs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.ModelChain.dc_ohms_from_percentdecides whetherresults.dcis a tuple from the input shape, butPVSystem.dc_ohms_from_percent()unwraps to a scalar for a single-Array system regardless of input shape. So a single-Array system given a length-1 list/tuple storedresults.dcas a tuple whileRwcame back as a float, andzip(Rw, self.results.dc)raisedTypeError: 'float' object is not iterable.Passing
unwrap=Falsein the tuple branch keepsRwa tuple so the two paths agree, mirroring how the rest of_run_from_effective_irradalready calls the multi-array helpers. The scalar path is unchanged.