perf: accelerate imports and harden large-library recovery - #137
Merged
Conversation
added 9 commits
September 2, 2026 22:27
Use container-aware inspection budgets for Mylar and folder imports, batch review-row inserts, and skip impossible singleton duplicate checks. Cache repeated page-title parsing and bound Step 4 task submission while preserving safety, cancellation, and rollback ownership. Correct current-item completion and unknown ETA rendering. Add regression tests, benchmark controls, and runtime timing/resource evidence. Validated with make ci-full: 10,519 Python tests, 90.49% coverage, Chromium/Firefox, accessibility, container security, and Docker smoke tests.
Calculate Mylar scan ETA from completed source batches, preserve progress across review phase transitions, and batch safety-only review summaries without hiding remaining work. Add regression coverage and realistic multipage scale fixtures while preserving source archives and import safety decisions.
Keep fractional metadata and file progress for Step 4 ETA calculations instead of deriving remaining time from rounded display percentages. Use a fresh execution clock for remaining work after pause or restart while preserving elapsed-time reporting. Cover large imports and large single groups across live updates, durable snapshots, and background progress for both Mylar and folder imports.
Publish the current recovery snapshot instead of stale preparation state after completion. Send worker progress directly to the shared activity feed so updates do not depend on modal polling. Add regression coverage for live progress, completed and partial recoveries, failure state, and activity expiration.
Batch and cache ComicVine profile, catalog, and issue requests so visible library metadata hydrates first while ComicInfo enrichment continues independently. Disable manual metadata refresh during initial synchronization and validate deferred archive targets before mutation.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6d2eb2d95e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dhi2todhi3; the High-severity container gate remains enabled.Why
Large, long-lived Mylar libraries exposed avoidable provider work, archive-inspection bottlenecks, misleading progress, and recovery paths that required too much manual intervention. This keeps successful imports usable while making exceptional files easier and safer to retry.
This work advances #112 while retaining explicit review for ambiguous or unsafe source material.
Validation
make ci-fullReview notes
CVE-2026-85091, exactdhi3package revisions, and the existing 2026-10-04 re-review deadline.