Fix infinite DNS retry loop when IPv6 DNS servers are unreachable - #253
Merged
Conversation
…chable Clear the IPv6 address buffer in `get_dns_ip()` when a server is skipped due to prior failure marking, so `user_provided_ipv6_dns` correctly becomes false and the rotation falls through to IPv4 DNS servers.
parfeon
added
priority: high
Contributor
Author
|
@pubnub-release-bot release |
Contributor
|
🚀 Release successfully completed 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(dns): Fix infinite DNS retry loop when IPv6 DNS servers are unreachable
Clear the IPv6 address buffer in
get_dns_ip()when a server is skipped due to prior failure marking, souser_provided_ipv6_dnscorrectly becomes false and the rotation falls through to IPv4 DNS servers.