Fix/lazy yaml import - #29
Merged
Merged
Conversation
The top-level 'yaml' import in bench-kit.ts is pulled in by index.ts, so every CLI start paid for loading the YAML parser and the binary smoke test's 50ms startup budget blew on CI (~58ms). Import yaml dynamically inside registerBaseRepo — the only code path that needs it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Local measurements show bench-kit added no startup cost (~38ms avg at pre-bench-kit, merged, and lazy-import refs alike) — the 50ms budget was simply too tight for shared CI runners, which hover just above it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.