Add ldap to the web client's protocol list - #243
Open
nashcontrol wants to merge 1 commit into
Open
Conversation
interactsh-server correlates LDAP search interactions to the payload's correlation id and returns them in the encrypted data array, but the client filters everything against a hardcoded ['dns','http','https','smtp'] list, so those rows were dropped before reaching the table. LDAP interactions come back without a raw-response, so hide the response pane and the request/response toggle for them, same as smtp. Refs projectdiscovery#95
|
@nashcontrol is attempting to deploy a commit to the ProjectDiscovery Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
interactsh-server correlates LDAP search interactions to the payload's correlation id and returns them in the encrypted
dataarray, but the client filters every interaction againstprotocols, which was hardcoded todns/http/https/smtp. Those rows were decrypted and then dropped before reaching the table.Same shape as #237, which added
https.ldapadded toprotocolsand todefaultFilter(the second is required, sinceFilterisRecord<Protocol, boolean>)raw-response, so the response pane and the request/response toggle are hidden for them, the waysmtpalready isNo migration needed for existing sessions:
getStoredDatamergesdefaultFilterover the persisted filter, added in #237 for the same reason.Tested against a self-hosted server:
ldapsearchwith the payload label in the base DN produces oneldaprow,full-idmatching the payloadldap, so no separateldapsentry is neededTwo things worth knowing:
extrafield, which this client doesn't read. Adding smb/ftp/responder from Support for LDAP, Wildcard and additional protocol interaction in web client #95 needs that field implemented first, plus a decision about surfacing server-wide data in a per-payload view. Happy to open a separate issue for it.Refs #95