various fixes for handling ensembles with selections as ref#1807
Open
jamesmkrieger wants to merge 7 commits into
Open
various fixes for handling ensembles with selections as ref#1807jamesmkrieger wants to merge 7 commits into
jamesmkrieger wants to merge 7 commits into
Conversation
jamesmkrieger
marked this pull request as draft
December 18, 2023 19:12
Contributor
Author
|
I guess this still needs some more rigorous checking, but it seems like everything works now. |
AnthonyBogetti
marked this pull request as ready for review
August 19, 2025 20:28
AnthonyBogetti
self-requested a review
August 19, 2025 20:28
Member
|
Hi @jamesmkrieger can you update this branch again? Then I can test it out. Thanks. |
Contributor
Author
|
Thanks. It's updated now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are some first fixes towards addressing #1663
There is likely still more to fix