Release v0.6.1 - #185
Merged
Merged
Conversation
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cuts 0.6.1. Five commits have been sitting on
mainsince 0.6.0, three of which fix ways a remote peer could crash, wedge or confuse the relay.Why now
0.6.0 is what is currently published, and these are not cosmetic:
Version drift, which is why this touches six files
The version lives in four places and only two of them were checked.
nix/package.nixhad already drifted, reporting 0.5.10 for two releases before #182 caught it. The other unguarded copy is the one users actually see:src/nip11.zigis what the relay reports over the wire.scripts/verify-nix-deps.shnow checks all four againstbuild.zig.zonas the source of truth. Mutation-tested by breaking each independently:nix/package.nix→ caughtsrc/main.zig(startup log) → caughtsrc/nip11.zig(NIP-11 document) → caughtVerified over the wire rather than by reading the diff: the built relay logs
Wisp v0.6.1 startingand answers NIP-11 with"version":"0.6.1".Release notes
The changelog entry describes each fix in terms of what a relay operator would observe, not in terms of the internals. Where a bug behaves differently between the safety-checked and release builds, it says so, since that difference determines whether an operator sees a crash or silent corruption.
Verification
zig build test65/65, protocol suite 45/45,verify-nix-deps.shandverify-vendored-httpz.shboth clean.Not blocked on upstream
Worth recording since it has come up: the relay builds from
vendor/httpz, not from an upstream fetch, and CI gates the vendored tree against upstream plusvendor/httpz.patch. Whether upstream adopts these fixes changes nothing about what this release contains. Upstreaming remains worth doing to retire the cost of re-applying the patch on every re-pin, but it is not a release gate.Review follow-up: six factual errors in the release notes, corrected
The review was pointed at accuracy of the operator-facing text, and it found six wrong claims. Each is verified against git history, not just accepted:
git log -Son the hash inbuild.zig.zongit tag --contains 424e2f0git show --staton bothAlso corrected: #184's trigger is memory pressure or the per-user watch limit, not memory pressure alone.
Two non-factual fixes from the same review: bullets are now single unbroken lines matching every other entry in the file, since wrapped bullets render as ragged line breaks in a GitHub release body; and
### Changednow precedes### Fixed, matching 0.6.0 and Keep a Changelog.And a real bug in the new script: under
set -euo pipefail,zon_version="$(grep ... | head -1)"exits the script the moment grep finds nothing, so the friendly "could not read .version" message below it was unreachable and CI would have shown a bare exit 1. Fixed and verified by breakingbuild.zig.zondeliberately: the message now prints.Summary by CodeRabbit
New Features
Bug Fixes
Chores