test: Cover all opt-in hash types in the ECDSA sighash roundtrip - #1
Closed
oj43bc wants to merge 144 commits into
Closed
test: Cover all opt-in hash types in the ECDSA sighash roundtrip#1oj43bc wants to merge 144 commits into
oj43bc wants to merge 144 commits into
Conversation
Co-authored-by: Kurtis Stirling <knotkurtis@gmail.com> Co-authored-by: Luke Dashjr <luke-jr+git@utopios.org>
8-bit icon is required to make builds deterministic (CMake rewrite of ea29400, except image tools are required)
(CMake rewrite of d22aa1d)
(CMake rewrite of 09bbed8)
(CMake rewrite of 5c3890f)
This has been the case in Bitcoin Core since 0.15
kwsantiago
force-pushed
the
hf-sighash-opt-in
branch
28 times, most recently
from
August 27, 2026 02:34
1e5aea6 to
4de04c9
Compare
Collaborator
|
Landed on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unified_sighash_sign_and_verify_roundtripsignedSIGHASH_ALLonly, so the other five hash types the opt-in bit defines were never produced or verified through an ECDSA spend.unified_sighash_taproot_keypath_roundtripcovers all six, but it is schnorr.Loops the existing signing block over ALL, NONE and SINGLE, each with and without ANYONECANPAY.
No behaviour change.
sighash_testspasses.