Enable assembly generation - #2770
Merged
Merged
Conversation
Jarod42
reviewed
Aug 13, 2026
theComputeKid
force-pushed
the
assembly
branch
from
August 13, 2026 09:06
a466eb6 to
689de01
Compare
Jarod42
approved these changes
Aug 13, 2026
nickclark2016
requested changes
Aug 17, 2026
theComputeKid
force-pushed
the
assembly
branch
from
August 17, 2026 09:40
689de01 to
37c6a60
Compare
Contributor
Author
|
@nickclark2016 : I have changed the flag's scope from config to per file, which makes more sense for a flag that enables assembly generation. Can you please review if I did it correctly? |
theComputeKid
force-pushed
the
assembly
branch
3 times, most recently
from
August 17, 2026 12:42
a590575 to
8ab3df9
Compare
nickclark2016
requested changes
Aug 17, 2026
nickclark2016
left a comment
nickclark2016
left a comment
Member
There was a problem hiding this comment.
Overall code looks really good. Just one, hopefully trivial, comment to fix up.
- GCC and Clang use `-save-temps=obj` when `generateassembly` is `On`. `Verbose` additionally uses `-fverbose-asm`. - MSVC uses `/FA` for `On` and `/FAs` for `Verbose`. - Assembly is output in the object directory. Some logic has been added to msc to avoid output name clashes, by deriving it from the object file name. Future work can decouple assembly generation and output location. But having asm output to the object directory is one of its main workflows when you want to inspect the assmebly for optimization purposes.
theComputeKid
force-pushed
the
assembly
branch
from
August 17, 2026 16:19
8ab3df9 to
4ed6a16
Compare
nickclark2016
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-save-temps=objwhengenerateassemblyisOn.Verboseadditionally uses-fverbose-asm./FAforOnand/FAsforVerbose./Fa$(asm_name).asmfor msvc-syntax compilers. This requires modifying the vs/ninja/makefile generators for those compilers.Future work can decouple assembly generation and output location. But having asm output to the object directory is a good starting point and a very common use case when you want to inspect the assembly for optimization purposes.