Add appmanifest config option for dotnet projects - #2769
Open
CapeGuyBen wants to merge 1 commit into
Open
Conversation
CapeGuyBen
changed the title
Jarod42
reviewed
Aug 12, 2026
|
|
||
| function dotnetbase.netcore.appManifest(cfg) | ||
| if cfg.appmanifest and string.len(cfg.appmanifest) > 0 then | ||
| _p(2,'<ApplicationManifest>%s</ApplicationManifest>', cfg.appmanifest) |
Contributor
There was a problem hiding this comment.
To which path should it be relative?
Contributor
Author
There was a problem hiding this comment.
It's relative to the generated .csproj
Contributor
There was a problem hiding this comment.
Paths are entered relative to premake5.lua, so a path.getrelative seems missing here.
Contributor
Author
There was a problem hiding this comment.
Makes sense. Added.
CapeGuyBen
force-pushed
the
feature/dotnet_app_manifest
branch
from
August 14, 2026 14:17
d478f16 to
a7ccd46
Compare
nickclark2016
requested changes
Aug 17, 2026
|
|
||
| ## Applies To ### | ||
|
|
||
| .Net project configurations. |
Member
There was a problem hiding this comment.
We should be consistent. .NET or dotnet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds an appmanifest config option for adding an
<ApplicationManifest>properties to dotnet projects.Resolves Issue 622.
How does this PR change Premake's behavior?
You can now add
<ApplicationManifest>properties to dotnet projectsDid you check all the boxes?
closes #XXXXin comment to auto-close issue when PR is merged)