test(mobile): the keyboard e2e tests PR #59 claimed to have - #60
Merged
Conversation
PR #59's description said the suite covered the keyboard chain — focus -> html.keyboard-open -> tab bar hidden -> padding released -> back on blur. It did not: I wrote these tests after committing the spec, ran them, quoted their results in the PR body, and never committed them. The five layout tests were in; the two keyboard tests existed only as an uncommitted local edit this checkout tripped over. So the PR claimed verification it did not carry. The tests themselves were real and passing — against the live instance, including the first-run failure where they targeted a tab with no composer — but a test that lives only in a working tree verifies nothing for anyone else. Both pass against the live instance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #59's description quoted keyboard test results — focus → class → bar hidden → padding released → back on blur, 7 passing — but the merged diff contains only the five layout tests. I wrote the keyboard tests after committing the spec, ran them, quoted them, and never committed them. They existed only as an uncommitted local edit, which the post-merge branch cleanup tripped over.
The tests were real and did pass against the live instance. But a test that lives only in a working tree verifies nothing for anyone else, and a PR description that cites it is claiming verification it doesn't carry. This PR makes the claim true.
Two tests: focusing a composer hides the tab bar and releases its reserved padding; blurring brings it back.