Skip to content

updated Zfp==1.0.1 and tested on ubi10.2 - #8720

Open
tejasBadjateIBM wants to merge 4 commits into
ppc64le:masterfrom
tejasBadjateIBM:zfp_ubi10.2
Open

updated Zfp==1.0.1 and tested on ubi10.2#8720
tejasBadjateIBM wants to merge 4 commits into
ppc64le:masterfrom
tejasBadjateIBM:zfp_ubi10.2

Conversation

@tejasBadjateIBM

Copy link
Copy Markdown
Contributor

Checklist

  • Have you checked and followed all the points mention in the CONTRIBUTING.MD
  • Have you validated script on UBI 10.2 container
  • Did you run the script(s) on fresh container with set -e option enabled and observe success ?
  • Did you have Legal approvals for patch files ?

@prathamesh-ibm prathamesh-ibm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

if [[ "$MAJOR" -gt 3 ]] || { [[ "$MAJOR" -eq 3 ]] && [[ "$MINOR" -ge 12 ]]; }; then
echo "Python version is >= 3.12, installing numpy 2.5.0..."
python3.14 -m pip install cython numpy==2.5.0 wheel
else

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Else block will never be executed as we are installing python 3.14. The conditional block can be removed and we can install the required dependent pkg versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants