Reconcile the iLert operator alert stream - #565
Open
morgaesis wants to merge 7 commits into
Open
Conversation
There was a problem hiding this comment.
1 blocking finding open
1 finding posted inline
1 suppressed
- Manual alert tests no longer trigger notifications at
.github/workflows/production-monitor.yml:452: below the configured confidence threshold; severity error, confidence 0.04. The notification job now runs only when the smoke job fails, so manual runs withtest_alert=trueskip the external alert. Preserve the operator-requested test-alert branch and its delivery verification.
There was a problem hiding this comment.
1 blocking finding open
1 finding posted inline
3 suppressed
- Allow the manual canary to run when smoke fails at
.github/workflows/production-monitor.yml:540: cites a line the named construct does not sit on; severity warn, confidence 0.94. Because this job needssmokeand its condition is not wrapped inalways(), GitHub Actions skips the job whensmokefails or is cancelled, even wheninputs.test_alertis true. This regresses the prior manual test-alert path, which could validate delivery during monitor failures. Remove the dependency or use an always-evaluated condition that explicitly permits the manual canary to run. - Preserve external alerts for manual test runs at
.github/workflows/production-monitor.yml:598: cites a line the named construct does not sit on; severity warn, confidence 0.98. This condition removed theinputs.test_alert == truebranch, so a manually requested test run no longer reaches the external alert action even when the test is intended to verify alert delivery. Retain the test-alert condition or otherwise route test runs to the alert action without affecting production failure handling. - Restore test-alert notification delivery at
.github/workflows/production-monitor.yml:598: below the configured confidence threshold; severity error, confidence 0.04. The notification job no longer runs for operator-requested test alerts, so successful smoke and recovery checks cannot exercise the external alert path. Restore the test-alert condition or invoke an equivalent explicit alert action.
Contributor
Author
|
@postil re-review |
There was a problem hiding this comment.
review incomplete ·
1 blocking finding open
1 finding posted inline
1 suppressed
- Preserve operator-requested test alerts at
.github/workflows/production-monitor.yml:598: cites a line the named construct does not sit on; severity error, confidence 0.94. This condition removed theinputs.test_alert == truebranch. When an operator requests a test alert and both prerequisite jobs pass,notifyis skipped, so the alerting path cannot be tested and the requested external alert is never sent. Include|| inputs.test_alert == truein the condition, while preserving the existing failure and cancellation cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Operator alert monitoring no longer depends on a renewable local login to configure iLert. The manual production-monitor canary uses the existing GitHub OIDC identity to reconcile one fail-closed webhook action, verifies successful create and resolve deliveries through iLert action history, and always cleans up its unique alert; routine production failures retain their existing alert lifecycle.