Align smoke-install cosign version, add curl retries, and log the source-build fallback - #5
Merged
Merged
Conversation
…retries, and note the source-build fallback The self-test job pinned a newer cosign-installer than action.yml itself, so it verified a different cosign than what ships; pin both to the same SHA. Add retry flags to the install path's curl calls so a transient network blip does not fail the whole job, and emit a ::notice:: when no prebuilt target matches the runner so the source-build fallback is not silent. Document timeout-minutes in the README usage example so callers bound a hung review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The smoke-install job pinned a newer cosign-installer than action.yml itself ships, so the self-test verified a different cosign binary than what runs in production; both now pin the same SHA/version. The install path's curl calls (GitHub API commit lookup, release asset downloads, rustup bootstrap) get retry flags so a transient network blip doesn't fail the whole job. When no prebuilt target matches the runner (non-Linux, or an unrecognized architecture), the action now emits a ::notice:: instead of silently falling through to a source build. The README usage example adds timeout-minutes so callers bound a hung review job.