Open the report card's analysis link on that pilot's track alone - #665
Merged
Conversation
The button under the report card map loaded the whole field, so the analysis panel came up in multi-track mode — Competition Score and Task, the two things the report card already shows. A reader who followed it wanted the flight, not the field: Events, Glides, Climbs and Sinks. `pilotId` now narrows the track list instead of pre-focusing a pilot inside it. One track puts the panel in single-track mode, where those tabs live. An id that matches no track falls back to the whole field with a warning rather than an empty map. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Preview Deployment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preview: https://claude-analysis-map-full-tab.glidecomp.pages.dev
(the analysis viewer is sign-in gated; the button is on
/comp/:id/task/:id/pilot/:id, under the map)Why
The report card's map carries a button — "Open full track in the analysis
map" — that opened
/analysis?compId=…&taskId=…&pilotId=…. That URL loadedevery track on the task and used
pilotIdonly to pre-select the pilot inthe field. Loading more than one track puts the analysis panel in multi-track
mode, whose tab row is Competition Score · Task — the two things the report
card the reader just left already shows them.
A reader who follows that button wants the flight, not the field: the per-track
tools, Task · Score · Events · Glides · Climbs · Sinks.
What changed
loadCompTask(web/frontend/src/analysis/main.ts) now treatspilotIdas aFILTER over the task's track list rather than a pre-focus inside it. One track
means
loadMultipleIGCFilestakes its existing single-track path, which isalready what swaps the tab row back — no tab logic changed, and nothing new was
added to
analysis-panel.ts.The task itself is unchanged: the comp's
xctsk, its GAP parameters and thebreadcrumbs all still load, so the Task and Score tabs read the competition's
route rather than a bare track.
Two consequences worth naming:
— "That pilot has no track on this task — showing the whole field" — rather
than an empty map. New copy; happy to reword.
setPilotSelectiononly ever applied to themulti-track score table, which this path no longer reaches.
The link and its tooltip are untouched — "full track" describes the new
behaviour better than the old one. Only stale comments in
PilotScoreDetail.tsxwere updated.
/analysis?compId=…&taskId=…with nopilotId— the task page's own "Analysis"link — is deliberately unchanged and still loads the field.
Verification
Driven with Playwright against a locally seeded Corryong Cup 2026 (the in-app
browser stalls on Mapbox, per the run-glidecomp notes):
?compId=culx&taskId=culx&pilotId=iqgp→ single-track row, all six tabs,flight info
Steve Blenkinsop | 1/5/2026 | 3h 0m | 48.99 mi, breadcrumbsCorryong Cup 2026 › Task 1 (Open).Score
TP5 reached – TINTAL, 4 of 7 legs, Task8 turnpoints · 48.99 mi.pilotId: 32 tracks,Competition Score · Task,32 pilots | 48.99 mi— unchanged.pilotId: falls back to the 32-track field as designed.bun run typecheck:allclean; frontend vitest 717/717.No engine source changed, so no scoring-change note is owed; nothing here
mutates competition data, so no
audit()orbumpAndRevalidateScores()callsites are involved.
Not changed
The sidebar still starts collapsed until the reader presses Analysis — that
is the analysis page's behaviour for every entry into it, not something this
link controls. Auto-opening it for comp deep-links is a separate call.
🤖 Generated with Claude Code