Skip to content

Open the report card's analysis link on that pilot's track alone - #665

Merged
pokle merged 1 commit into
masterfrom
claude/analysis-map-full-tabs-d129f4
Aug 23, 2026
Merged

Open the report card's analysis link on that pilot's track alone#665
pokle merged 1 commit into
masterfrom
claude/analysis-map-full-tabs-d129f4

Conversation

@pokle

@pokle pokle commented Aug 23, 2026

Copy link
Copy Markdown
Owner

Preview: https://claude-analysis-map-full-tab.glidecomp.pages.dev
(the analysis viewer is sign-in gated; the button is on
/comp/:id/task/:id/pilot/:id, under the map)

Why

The report card's map carries a button — "Open full track in the analysis
map"
— that opened /analysis?compId=…&taskId=…&pilotId=…. That URL loaded
every track on the task and used pilotId only to pre-select the pilot in
the field. Loading more than one track puts the analysis panel in multi-track
mode, whose tab row is Competition Score · Task — the two things the report
card the reader just left already shows them.

A reader who follows that button wants the flight, not the field: the per-track
tools, Task · Score · Events · Glides · Climbs · Sinks.

What changed

loadCompTask (web/frontend/src/analysis/main.ts) now treats pilotId as a
FILTER over the task's track list rather than a pre-focus inside it. One track
means loadMultipleIGCFiles takes its existing single-track path, which is
already what swaps the tab row back — no tab logic changed, and nothing new was
added to analysis-panel.ts.

The task itself is unchanged: the comp's xctsk, its GAP parameters and the
breadcrumbs all still load, so the Task and Score tabs read the competition's
route rather than a bare track.

Two consequences worth naming:

  • An id that matches no track falls back to the whole field, with a warning
    "That pilot has no track on this task — showing the whole field" — rather
    than an empty map. New copy; happy to reword.
  • The pre-focus block is gone. setPilotSelection only ever applied to the
    multi-track score table, which this path no longer reaches.

The link and its tooltip are untouched — "full track" describes the new
behaviour better than the old one. Only stale comments in PilotScoreDetail.tsx
were updated.

/analysis?compId=…&taskId=… with no pilotId — the task page's own "Analysis"
link — is deliberately unchanged and still loads the field.

Verification

Driven with Playwright against a locally seeded Corryong Cup 2026 (the in-app
browser stalls on Mapbox, per the run-glidecomp notes):

  • ?compId=culx&taskId=culx&pilotId=iqgp → single-track row, all six tabs,
    flight info Steve Blenkinsop | 1/5/2026 | 3h 0m | 48.99 mi, breadcrumbs
    Corryong Cup 2026 › Task 1 (Open).
  • Every tab renders real content: Events 414, Glides 28, Climbs 45, Sinks 0,
    Score TP5 reached – TINTAL, 4 of 7 legs, Task 8 turnpoints · 48.99 mi.
  • Control, same task without pilotId: 32 tracks, Competition Score · Task,
    32 pilots | 48.99 mi — unchanged.
  • Unknown pilotId: falls back to the 32-track field as designed.
  • bun run typecheck:all clean; frontend vitest 717/717.

No engine source changed, so no scoring-change note is owed; nothing here
mutates competition data, so no audit() or bumpAndRevalidateScores() call
sites are involved.

Not changed

The sidebar still starts collapsed until the reader presses Analysis — that
is the analysis page's behaviour for every entry into it, not something this
link controls. Auto-opening it for comp deep-links is a separate call.

🤖 Generated with Claude Code

The button under the report card map loaded the whole field, so the
analysis panel came up in multi-track mode — Competition Score and Task,
the two things the report card already shows. A reader who followed it
wanted the flight, not the field: Events, Glides, Climbs and Sinks.

`pilotId` now narrows the track list instead of pre-focusing a pilot
inside it. One track puts the panel in single-track mode, where those
tabs live. An id that matches no track falls back to the whole field
with a warning rather than an empty map.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

Preview Deployment
https://ae379f57.glidecomp.pages.dev
Commit: 42345c8

@pokle
pokle merged commit a02e40e into master Aug 23, 2026
6 checks passed
@pokle
pokle deleted the claude/analysis-map-full-tabs-d129f4 branch August 23, 2026 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant