Skip to content

fix(typescript): export ServerManagerOptions#1847

Open
ColumbusLabs wants to merge 1 commit into
pmxt-dev:mainfrom
ColumbusLabs:codex/export-server-manager-options
Open

fix(typescript): export ServerManagerOptions#1847
ColumbusLabs wants to merge 1 commit into
pmxt-dev:mainfrom
ColumbusLabs:codex/export-server-manager-options

Conversation

@ColumbusLabs

Copy link
Copy Markdown

Summary

  • export ServerManagerOptions from the TypeScript package root
  • add compile-time regression coverage using the public entry point

This makes the options type available alongside ServerManager, matching the existing root exports for RouterOptions, FeedClientOptions, and other constructor option types.

Verification

  • npm test --workspace=pmxtjs -- --runInBand --watchman=false tests/public-exports.test.ts (6 tests passed)
  • npm run build --workspace=pmxtjs (CommonJS and ESM builds passed)
  • git diff --check

The broader TypeScript run completed 12 of 17 suites (67 of 94 tests). Five unrelated network-mocking suites could not install their fetch spies because this local Node 26/Jest environment did not expose global.fetch inside the Jest sandbox; the changed public-export suite and both package builds pass.

Closes #1840

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SDK drift: ServerManagerOptions type is never re-exported from the TypeScript package root, unlike sibling options types

1 participant