Fix attachFile() forwarding relative paths to the Node bridge - #6
Merged
Merged
Conversation
Member
|
Thank you @poman and sorry for the delay |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5
PlaywrightDriver::attachFile()passed the path string as-is to the Node bridge, which resolves relative paths against its own cwd (vendor/playwright-php/playwright/bin), not the PHP process cwd. Any path valid forfile_exists()on the PHP side could fail with ENOENT on the Node side.Resolves the path via
realpath()before it crosses the process boundary, and throws a clearDriverExceptionwhen the path does not exist instead of a confusing bridge-side ENOENT.Testing
attachFile()fails withENOENT: no such file or directory, stat 'upload.txt'.tests/Driver/AttachFileRelativePathTest.php(wired into a new "Regression tests" phpunit suite) covering both the success path and the missing-file error path — verified green with the fix, verified it reproduces the original failure without it.php-cs-fixer --dry-runclean;phpstan analyseshows only 3 pre-existing, unrelated errors (same on main before this change).