Skip to content

fix: restore block-tools publish/mark-stable scripts #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blackcat merged 1 commit into from
Jun 5, 2026
Merged

fix: restore block-tools publish/mark-stable scripts #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/restore-block-publish.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@platforma-open/milaboratories.gpu-test": patch
---

Restore `prepublishOnly` and `mark-stable` scripts in `block/package.json`.

Both were silently dropped in commit `d60844a` ("PyTorch added, matrix size selection added", Apr 30) — the diff line `block/package.json | 2 --` slipped in unmentioned in the body. Effect: from v0.6.0 onward, `pnpm -r publish` no longer uploaded the block-pack to `s3://milab-euce1-prod-pkgs-s3-block-registry/pub/releases/`, so versions 0.6.0 / 0.7.0 / 0.7.1 never reached `https://blocks.pl-open.science/v2/milaboratories/gpu-test/<version>/manifest.json` and never showed up in the Desktop block picker (still pinned at 0.5.2, the last version published before the regression). npm and the software registry kept working — only the block-registry upload was broken. Sibling repo `platforma-open/titeseq-analysis` still carries both scripts; restoring matches that template.
2 changes: 2 additions & 0 deletions block/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
"version": "0.7.1",
"scripts": {
"build": "shx rm -rf ./block-pack && block-tools pack",
"mark-stable": "block-tools mark-stable -r 's3://milab-euce1-prod-pkgs-s3-block-registry/pub/releases/?region=eu-central-1'",
"prepublishOnly": "block-tools pack && block-tools publish -r 's3://milab-euce1-prod-pkgs-s3-block-registry/pub/releases/?region=eu-central-1'",

@greptile-apps greptile-apps Bot Jun 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 The prepublishOnly script calls block-tools pack without first removing ./block-pack, whereas the build script explicitly does shx rm -rf ./block-pack before packing. If a stale ./block-pack directory is present from a previous run, old artifacts could be included in the published block-pack. Consider adding the clean step here for consistency with build and to guarantee a fresh pack on every publish.

Suggested change
"prepublishOnly": "block-tools pack && block-tools publish -r 's3://milab-euce1-prod-pkgs-s3-block-registry/pub/releases/?region=eu-central-1'",
"prepublishOnly": "shx rm -rf ./block-pack && block-tools pack && block-tools publish -r 's3://milab-euce1-prod-pkgs-s3-block-registry/pub/releases/?region=eu-central-1'",
Prompt To Fix With AI 
This is a comment left during a code review.
Path: block/package.json
Line: 7

Comment:
The `prepublishOnly` script calls `block-tools pack` without first removing `./block-pack`, whereas the `build` script explicitly does `shx rm -rf ./block-pack` before packing. If a stale `./block-pack` directory is present from a previous run, old artifacts could be included in the published block-pack. Consider adding the clean step here for consistency with `build` and to guarantee a fresh pack on every publish.

```suggestion
    "prepublishOnly": "shx rm -rf ./block-pack && block-tools pack && block-tools publish -r 's3://milab-euce1-prod-pkgs-s3-block-registry/pub/releases/?region=eu-central-1'",
```

How can I resolve this? If you propose a fix, please make it concise.

"do-pack": "shx rm -f *.tgz && block-tools pack && pnpm pack && shx mv *.tgz package.tgz"
},
"files": [
Expand Down
Loading