Fix database dump silent failures on cursor close errors - #1343
Merged
Conversation
Commit 4d3dc85 replaced an explicit cursor.Close() check with defer cursor.Close(), which swallowed stream errors from go-mysqlstack that only surface when the cursor is closed after Next() stops. Also propagate dumpTable errors from errgroup workers so failed dumps return a non-zero exit code instead of logging and continuing. Co-authored-by: Gomez <no-itsbackpack@users.noreply.github.com>
no-itsbackpack
marked this pull request as ready for review
August 17, 2026 17:14
nholden
approved these changes
Aug 17, 2026
Keep Close error reporting via a named return defer so mid-loop failures still drain the stream before the connection returns to the pool. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Avoid a misleading "dumping table done" log when the deferred stream close is what fails the dump. Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
There are 3 total unresolved issues (including 2 from previous reviews).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c144386. Configure here.
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Fixes a regression introduced in commit
4d3dc85wherepscale database dumpcould finish successfully after a partial dump when the MySQL stream failed mid-query.Root cause
When refactoring
dumpTablefor multiple output formats, the explicitcursor.Close()error check was replaced withdefer cursor.Close(). Ingo-mysqlstack, stream errors (e.g.unexpected EOF,closed network connection) are often only returned fromClose()afterNext()stops, so those errors were swallowed anddumpTablereturned success.Changes
cursor.Close()check after finishing the row loop and writer flush.dumpTableerrors from errgroup workers soRun()fails andpscale database dumpexits non-zero.