Rebase patches onto upstream v1.37.0 - #29
Merged
Merged
Conversation
Fixes #23. Upstream v1.37.0 restructured the contrib modules, which broke the patch series in three ways: - Upstream added its own `temporal-opentelemetry` contrib module (a Tally-> OTel metrics/stats reporter built on the opentracing-shim). It collides by name with the fork's native OTel *tracing* module. Renamed the fork module to `temporal-opentelemetry-tracing` so upstream and fork can never clash again on a bump; upstream's variant stays excluded (it needs the excluded temporal-opentracing and only does metrics, which we get natively). - The fork now ships `temporal-workflowstreams`. Enabling it under the Serde- only stack needed more than an include: its public-field wire DTOs get @Serdeable + @introspected(accessKind=FIELD) (Serde drops public fields otherwise), and its build.gradle needs the Serde annotation processor or @Serdeable compiles but generates no introspection (runtime SerdeException). - New contrib modules temporal-aws-lambda, plus upstream's temporal- opentelemetry, are excluded. aws-lambda hard-depends on temporal-envconfig (jackson-toml) and upstream temporal-opentelemetry (opentracing); resolving those is deferred. settings.gradle/temporal-bom reconciled for the new module layout; LocalActivityMarkerMetadata re-Serde-annotated onto upstream's javadoc change. Verified on JDK 25: :temporal-workflowstreams:test (37/37), :temporal-opentelemetry-tracing:test, and the SDK serde suites all pass; spotlessCheck clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.