Replace grpc-okhttp patch with real grpc-netty - #15
Merged
Marius Volkhart (MariusVolkhart) merged 1 commit intoJun 25, 2026
Conversation
Patch 0003 previously swapped upstream's grpc-netty-shaded for grpc-okhttp, which forced a full rewrite of SimpleSslContextBuilder onto the JDK SSLContext API and left temporal-envconfig referencing shaded netty classes that grpc-okhttp does not provide. Replace it with a mechanical de-shade to real io.grpc:grpc-netty so consuming applications control a single Netty version on their classpath. Real grpc-netty exposes the same GrpcSslContexts/SslContext APIs as the shaded variant, so the rewritten files revert to upstream form; the native-image metadata in temporal-serviceclient and temporal-test-server is de-shaded to match. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Marius Volkhart (MariusVolkhart)
deleted the
replace-okhttp-with-real-netty
branch
June 25, 2026 17:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.