Skip to content

Ask for custom-word translation language - #129

Merged
pirajoke merged 2 commits into
mainfrom
codex/custom-vocabulary-translation-language
Sep 9, 2026
Merged

Ask for custom-word translation language#129
pirajoke merged 2 commits into
mainfrom
codex/custom-vocabulary-translation-language

Conversation

@pirajoke

@pirajoke pirajoke commented Sep 9, 2026

Copy link
Copy Markdown
Owner

Summary

  • ask learners which language custom words should be translated into before accepting an import
  • persist this preference separately from the study language, interface language, and native language
  • apply the selection to text, photo, PDF, voice, practice, and Mini App custom-word lists
  • add migration 0022 and clear the preference during privacy erasure
  • localize the flow across all eight supported interface languages

Verification

  • RED: 7 regression tests failed for the intended behavior (4 failures, 2 errors)
  • GREEN: custom vocabulary suite 22/22 passed
  • affected suites: 166 passed (3 skipped)
  • full suite: 1046 passed (3 skipped)
  • migration upgrade/downgrade round trip passed
  • Python compileall and JavaScript syntax check passed
  • git diff --check passed

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 9, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-09T09:42:59.782558Z 43a90a7 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 43a90a7bb2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

import sqlalchemy as sa


revision = "0022_custom_vocabulary_translation_language"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Shorten the Alembic revision identifier

On the repository's PostgreSQL 16 path, Alembic stores revision identifiers in its default alembic_version.version_num VARCHAR(32) column, but this identifier is 43 characters long. After executing the migration, Alembic will fail when recording the new revision with a value too long error, rolling back the transaction and preventing every PostgreSQL deployment from advancing to this release; use an identifier no longer than 32 characters.

Useful? React with 👍 / 👎.

@pirajoke
pirajoke merged commit 23c9888 into main Sep 9, 2026
1 check passed
@pirajoke
pirajoke deleted the codex/custom-vocabulary-translation-language branch September 9, 2026 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant