Vary Lexi tutor response formats - #124
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d7b6dc12ad
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| def clean(value: str) -> str: | ||
| plain = re.sub(r"```[A-Za-z0-9_-]*", "", str(value)) | ||
| plain = re.sub(r"[💡📌👉]", "", plain) | ||
| plain = _MIRROR_APPLICATION_SECTION_MARKER_PATTERN.sub("", plain) |
There was a problem hiding this comment.
Because this substitution is unanchored and runs on every answer, language item, example, and next step, it removes the newly added glyphs even when they are the subject of the lesson rather than section decoration. For example, a translation request such as “Что значит ✅?” can legitimately return ✅ in both answer_ru and the language-item target, but both occurrences are deleted and the learner sees an incomplete explanation. Strip these markers only where they are acting as provider-supplied section prefixes, or otherwise preserve literal glyph content.
Useful? React with 👍 / 👎.
1 participant
Summary
Tests
.venv/bin/python -m unittest discover -s tests -v(1012 passed, 3 skipped).venv/bin/python -m compileall -q .git diff --checkSafety