Skip to content
This repository was archived by the owner on Aug 23, 2026. It is now read-only.

Enable approved tasks for protected agent Ping - #32

Merged
pirajoke merged 1 commit into
mainfrom
codex/enable-approved-task-runner
Aug 12, 2026
Merged

Enable approved tasks for protected agent Ping#32
pirajoke merged 1 commit into
mainfrom
codex/enable-approved-task-runner

Conversation

@pirajoke

Copy link
Copy Markdown
Owner

Root cause

The authenticated Ping process invoked the approved-task runner while inheriting , so a valid PONG always ended in a generic failed status.

Fix

  • opt into GitHub approved tasks only in the protected Ping child process
  • preserve process-wide configuration, auth, exact role, and fixed task boundaries
  • add a focused regression test

Evidence

  • intentional RED: child env inherited 0 instead of 1
  • GREEN: 163/163 builder tests pass
  • Python compile, zsh syntax, and diff checks pass

@pirajoke
pirajoke merged commit af36aaa into main Aug 12, 2026
1 check passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 04d5042692

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

"JARVIS_AGENT_BUDGET": "cheap",
"JARVIS_AGENT_SELF_HEAL_MAX_RETRIES": "0",
"JARVIS_AGENT_PING_ROLE": role,
"JARVIS_GITHUB_TASKS_ENABLED": "1",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve the ping opt-in after loading the agent env

When $HOME/.secrets/jarvis-agent.env contains JARVIS_GITHUB_TASKS_ENABLED=0, the child receives this new value as 1 but jarvis-agent-pipeline subsequently sources that file at lines 6–12, resetting the exported variable to 0 before invoking jarvis.dashboard_agent_runner; approved tasks therefore remain disabled in this production configuration. The regression test only inspects the Popen arguments and never runs the pipeline with an env file, so it cannot detect the override; preserve or reapply the protected-ping opt-in after the file is sourced.

Useful? React with 👍 / 👎.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant