Skip to content

spfresh: rename search beam request field #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lloyd-Pottiger merged 1 commit into from
Jul 7, 2026
Merged

spfresh: rename search beam request field #420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
126 changes: 63 additions & 63 deletions go-tipb/spfresh_search.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions proto/spfresh_search.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ message SPFreshSearchRequest {

// Optional tuning parameters.
double oversample_factor = 8;
// If zero, the server uses its default base beam size.
uint32 base_beam_size = 9;
// If zero, the server uses its default search beam size.
uint32 search_beam_size = 9;

// read_only disables background fixups (split/merge) triggered by search
// observations. When enabled, the server must not enqueue fixups and should
Expand Down
22 changes: 20 additions & 2 deletions scripts/proto.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2528,6 +2528,12 @@
"name": "runtime_filter_list",
"type": "RuntimeFilter",
"is_repeated": true
},
{
"id": 15,
"name": "is_null_eq",
"type": "bool",
"is_repeated": true
}
]
},
Expand Down Expand Up @@ -4462,6 +4468,18 @@
"name": "ApproxCountDistinct",
"integer": 3020
},
{
"name": "SumInt",
"integer": 3021
},
{
"name": "MinCount",
"integer": 3022
},
{
"name": "MaxCount",
"integer": 3023
},
{
"name": "RowNumber",
"integer": 4001
Expand Down Expand Up @@ -8502,7 +8520,7 @@
},
{
"id": 9,
"name": "base_beam_size",
"name": "search_beam_size",
"type": "uint32"
},
{
Expand Down Expand Up @@ -9613,4 +9631,4 @@
}
}
]
}
}
Loading