Skip to content

Drop DOCS_GENERATOR_ACCESS_TOKEN from docs workflow, downgrade to pull_request - #1135

Merged
berfinyuksel merged 1 commit into
2026.xfrom
devops/drop-docs-generator-token
Jul 30, 2026
Merged

Drop DOCS_GENERATOR_ACCESS_TOKEN from docs workflow, downgrade to pull_request#1135
berfinyuksel merged 1 commit into
2026.xfrom
devops/drop-docs-generator-token

Conversation

@berfinyuksel

Copy link
Copy Markdown
Contributor

Summary

Remove DOCS_GENERATOR_ACCESS_TOKEN from the docs workflow and downgrade its trigger from pull_request_target to plain pull_request.

The token was only needed to clone the private docs-generator; since pimcore/workflows-collection-public#135 (merged) vendors sanitized public tooling, no secret is needed: read-only token, no secret-exposure surface. Tracked in pimcore/product-management#1321 (org-wide cleanup, template: pimcore/pimcore#19292).

Changes

  • Drop the secrets: DOCS_GENERATOR_ACCESS_TOKEN block.
  • pull_request_targetpull_request.
  • Fix the stale paths entry .github/workflows/new-docs.ymldocs.yml, so changes to the docs workflow itself trigger a docs run.

Verification

The pattern is live-proven in pimcore/pimcore#19292 — its docs run is green on the exact tokenless @main path. This PR's own docs run (triggered by the fixed paths) verifies this repo.

🤖 Generated with Claude Code

Copilot AI review requested due to automatic review settings July 30, 2026 14:42
@berfinyuksel
berfinyuksel requested a review from bluvulture as a code owner July 30, 2026 14:42
@berfinyuksel berfinyuksel added this to the 2026.3.0 milestone Jul 30, 2026
@sonarqubecloud

Copy link
Copy Markdown

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Verdict: LGTM

Removes obsolete privileged docs-workflow access after tooling became public.

Changes:

  • Uses the safer pull_request trigger (.github/workflows/docs.yml:4).
  • Corrects both workflow path filters (:11, :20).
  • Removes the now-unneeded secret while retaining read-only permissions (:23-30).

Review contract: The root cause is addressed at the correct caller boundary. All local trigger paths are covered, no API compatibility or documentation concerns apply, and the PR’s successful workflow run provides direct regression verification. The existing mutable @main reference remains the only unverified operational risk.

@berfinyuksel
berfinyuksel merged commit 66815f1 into 2026.x Jul 30, 2026
19 checks passed
@berfinyuksel
berfinyuksel deleted the devops/drop-docs-generator-token branch July 30, 2026 15:22
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants