Studio Frontend Build: scope push trigger to version branches - #1130
Closed
berfinyuksel wants to merge 1 commit into
Closed
Studio Frontend Build: scope push trigger to version branches#1130berfinyuksel wants to merge 1 commit into
berfinyuksel wants to merge 1 commit into
Conversation
|
Contributor
There was a problem hiding this comment.
Pull request overview
Verdict: LGTM. The workflow now prevents duplicate PR builds by restricting push runs to version branches.
Changes:
- Adds version-branch filters to the push trigger (
.github/workflows/studio-frontend-build.yaml:5-7). - Keeps pull-request and path triggers unchanged.
The change addresses the root cause at the workflow boundary, covers the sole trigger, and introduces no API or compatibility changes. No documentation update is needed. Automated trigger regression testing has no practical local seam; post-merge verification remains advisable.
berfinyuksel
marked this pull request as draft
July 24, 2026 09:40
Contributor
Author
|
Closing: superseded by #1131 on the lowest applicable branch (2026.2). The change reaches 2026.x via upstream forward-merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the fleet-wide fix tracked in pimcore/DevOps-Tasks#2.
Problem
On PRs, Studio Frontend Build shows cancelled
(push)checks and a red "Some checks were not successful", because the workflow triggers on bothpushandpull_requestfor the same commit, landing in the same concurrency group (cancel-in-progressthen cancels one).Fix
Scope
pushto version branches (which have no PR); keeppull_requestfor all PRs. Each PR then triggers exactly one run — same-repo and fork PRs both build viapull_request(so external contributors still see if their change breaks the build), version branches build+commit via push, nothing collides.Paths are unchanged. Verify post-merge with an
assets/studio/**PR: one clean run, no cancelled(push).